fix: don't hardcode obsolete model for opencode agent#260
Closed
midnattsol wants to merge 0 commit intoroborev-dev:mainfrom
Closed
fix: don't hardcode obsolete model for opencode agent#260midnattsol wants to merge 0 commit intoroborev-dev:mainfrom
midnattsol wants to merge 0 commit intoroborev-dev:mainfrom
Conversation
roborev: Combined ReviewVerdict: ✅ No Medium/High/Critical issues identified in commit Findings (Medium+)No findings at Critical, High, or Medium severity after deduplicating all review outputs. Synthesized from 4 reviews (agents: codex, gemini | types: security, default) |
Collaborator
|
I tried pushing to your main branch but made a mess, I'll open a new PR I can control! |
5 tasks
wesm
added a commit
that referenced
this pull request
Feb 15, 2026
## Summary - Remove hardcoded `opencode/minimax-m2.1-free` model which is obsolete - Only pass `--model` flag when explicitly configured by user - Add tests for `CommandLine()` and `Review()` verifying `--model` is omitted when empty and present when set - Fix flaky `TestWorkerPoolCancelRunningJob` by initializing test dirs as real git repos with real commit SHAs, so prompt building succeeds and the job reaches the agent's `Review()` where cancellation can reliably fire Original fix by @midnattsol (supersedes #260). Test coverage added per review feedback. Fixes #259 ## Test plan - [x] `TestOpenCodeModelFlag` — verifies `CommandLine()` string output - [x] `TestOpenCodeReviewModelFlag` — verifies actual subprocess args via `mockAgentCLI` - [x] Existing `TestOpenCodeReviewFiltersToolCallLines` still passes - [x] `TestWorkerPoolCancelRunningJob` passes consistently under `-race -count=10` - [x] `TestWorkerPoolE2E` and `TestWorkerPoolConcurrency` now exercise the full prompt-build → agent-review path 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: midnattsol <juanjo@delasheras.dev> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
hughdbrown
pushed a commit
to hughdbrown/roborev
that referenced
this pull request
Feb 16, 2026
…-dev#264) ## Summary - Remove hardcoded `opencode/minimax-m2.1-free` model which is obsolete - Only pass `--model` flag when explicitly configured by user - Add tests for `CommandLine()` and `Review()` verifying `--model` is omitted when empty and present when set - Fix flaky `TestWorkerPoolCancelRunningJob` by initializing test dirs as real git repos with real commit SHAs, so prompt building succeeds and the job reaches the agent's `Review()` where cancellation can reliably fire Original fix by @midnattsol (supersedes roborev-dev#260). Test coverage added per review feedback. Fixes roborev-dev#259 ## Test plan - [x] `TestOpenCodeModelFlag` — verifies `CommandLine()` string output - [x] `TestOpenCodeReviewModelFlag` — verifies actual subprocess args via `mockAgentCLI` - [x] Existing `TestOpenCodeReviewFiltersToolCallLines` still passes - [x] `TestWorkerPoolCancelRunningJob` passes consistently under `-race -count=10` - [x] `TestWorkerPoolE2E` and `TestWorkerPoolConcurrency` now exercise the full prompt-build → agent-review path 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: midnattsol <juanjo@delasheras.dev> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opencode/minimax-m2.1-freemodel which is obsolete--modelflag when explicitly configured by userFixes #259