Strip CLAUDECODE env var when spawning claude-code agent#273
Merged
Conversation
When the daemon is started from within a Claude Code session (or hooks fire during one), the CLAUDECODE environment variable gets inherited by worker processes. Claude Code's nested-session guard then rejects the spawn with "cannot be launched inside another Claude Code session". Strip CLAUDECODE alongside ANTHROPIC_API_KEY when building the child process environment. Make filterEnv variadic to support multiple keys cleanly. Closes #270 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
roborev: Combined ReviewVerdict: No Medium, High, or Critical issues found; this change appears safe and security-positive. Findings (Medium+)No findings at Medium severity or higher after deduplicating all agent outputs. Synthesized from 4 reviews (agents: codex, gemini | types: security, default) |
The arrow characters (↑↓←→) are 3 bytes in UTF-8 but 1 terminal column wide. Using len() overestimated help line wrapping at widths 91-93, costing a visible row unnecessarily. Switch to runewidth.StringWidth() in both queue and review views. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
roborev: Combined ReviewVerdict: No Medium/High/Critical issues identified; changes look safe to merge. Findings (Medium+)No findings at Medium severity or above after deduplicating all review outputs. Synthesized from 4 reviews (agents: codex, gemini | types: security, default) |
go test on Windows can exit 1 when it fails to remove temp .exe
files due to OS file locking ("Access is denied"), even when all
tests pass. Check for actual FAIL lines in test output instead of
relying on the exit code alone.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Only suppress non-zero exit when the output contains "Access is denied" and no FAIL lines. Propagate all other non-zero exits (toolchain errors, module failures, etc.) as real failures. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
roborev: Combined ReviewVerdict: No Medium, High, or Critical issues found; PR is acceptable as-is. Findings (Medium+)None. All reported concerns were Low severity (primarily around CI heuristic robustness in Synthesized from 4 reviews (agents: codex, gemini | types: security, default) |
Split on first = and compare key portion exactly, preventing false matches when one key is a prefix of another (e.g. CLAUDE would have also stripped CLAUDECODE, CLAUDE_NO_SOUND). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Verify that stripping "CLAUDE" does not also strip "CLAUDECODE" or "CLAUDE_NO_SOUND" — the prefix-collision scenario that motivated the strings.Cut change. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
roborev: Combined ReviewVerdict: One Medium issue should be fixed before merge. Medium
Synthesized from 4 reviews (agents: codex, gemini | types: security, default) |
The PowerShell script was missing `exit 0` after suppressing the temp .exe cleanup error, so the non-zero exit code from `go test` propagated through. Also narrowed the match from "Access is denied" to the specific "go: remove ...\.exe: Access is denied" pattern to avoid masking unrelated permission failures. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
roborev: Combined ReviewVerdict: No Medium, High, or Critical issues identified across all reviews; the PR appears clean. Consolidated Findings (Medium+)No findings to report. Reviewer ConsensusAll four review outputs reported no issues, including both security-focused and general correctness/regression passes. Synthesized from 4 reviews (agents: codex, gemini | types: security, default) |
hughdbrown
pushed a commit
to hughdbrown/roborev
that referenced
this pull request
Feb 16, 2026
…#273) ## Summary - Strip `CLAUDECODE` from the child process environment when spawning the claude-code agent, preventing Claude Code's nested-session guard from rejecting the spawn - Make `filterEnv` variadic to support stripping multiple env vars cleanly - Add test for multi-key filtering Same class of fix as roborev-dev#267 (`GIT_DIR` stripping for daemon spawn). When the daemon starts from within a Claude Code session, or post-commit hooks fire during one, `CLAUDECODE` gets inherited by worker processes and Claude Code refuses to launch. Closes roborev-dev#270 ## Test plan - [x] `go test ./internal/agent/` passes (including new `TestFilterEnvMultipleKeys`) - [x] `go vet ./...` clean - [x] Manual: start daemon from within Claude Code session, verify reviews succeed 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLAUDECODEfrom the child process environment when spawning the claude-code agent, preventing Claude Code's nested-session guard from rejecting the spawnfilterEnvvariadic to support stripping multiple env vars cleanlySame class of fix as #267 (
GIT_DIRstripping for daemon spawn). When the daemon starts from within a Claude Code session, or post-commit hooks fire during one,CLAUDECODEgets inherited by worker processes and Claude Code refuses to launch.Closes #270
Test plan
go test ./internal/agent/passes (including newTestFilterEnvMultipleKeys)go vet ./...clean🤖 Generated with Claude Code