Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Docker #366

Merged
merged 6 commits into from
Jun 17, 2020
Merged

Improve Docker #366

merged 6 commits into from
Jun 17, 2020

Conversation

robbiet480
Copy link
Contributor

This PR does two things:

  • Ensures we are exiting with a proper exit code so that the program terminates
  • Reworks the Dockerfile to use best practices

Follow up from #365

@robbiet480 robbiet480 marked this pull request as ready for review June 16, 2020 00:51
@robbiet480 robbiet480 mentioned this pull request Jun 16, 2020
Closed
@robotastic robotastic merged commit d8d8923 into robotastic:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robbiet480 @robotastic