Add support for Python 3 #6
Conversation
| return 'Changing password failed: %s' % err | ||
| else: | ||
| return 'SUCCESS' | ||
|
|
||
| def save(self): | ||
| with open(self.db_file, 'w') as file: | ||
| for user in self.users.values(): | ||
| for user in list(self.users.values()): |
There was a problem hiding this comment.
Is list really needed here?
|
Good idea! Please look at the notes I added, tough. It would probably be a good idea to add It's a good idea also to mention in that the guide supports Python 3. Should it be mentioned both in README.rst and in QuickStartGuide.rst? Could you add such notes too? |
|
Your suggestions have been implemented. Notes on Python 3 have been added / updated too. |
|
Great! In a bigger project (e.g. Robot Framework) I would still ask you to squash commits, but I don't think that's really needed here. I also noticed on small typo but can easily fix it myself. |
|
Thanks again for the PR. Decided to create a new release with it: https://github.com/robotframework/QuickStartGuide/releases/tag/1.1 |
Minimal support for Python 3.
All tests pass with:
Robot Framework 3.0 (Python 2.7.5 on win32)
Robot Framework 3.0 (Python 3.4.3 on win32)
Note: I think the notice on Python 3 in QuickStart.rst should be updated if this pull request is accepted.