Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous javascript calls not implemented #20

Closed
emanlove opened this issue Dec 19, 2011 · 2 comments
Closed

Asynchronous javascript calls not implemented #20

emanlove opened this issue Dec 19, 2011 · 2 comments

Comments

@emanlove
Copy link
Member

There is no rf-s2l keyword to call WebDriver's execute_async_script or exercise this asynchronous functionality. Note there is currently browser keywords for setting the selenium timeout which as far as I can see is the timeout only for asynchronous JavaScript calls.

@emanlove
Copy link
Member Author

I've added tests and code for a rf-s2l keyword for executing asynchronous javascript calls within my fix-s2l-timeout-bug branch. The tests (test/acceptance/keywords/async_javascript.txt) mirror the same checks made by the selenium tests but using robotframework.

As I have not yet made the corrections for the set_selenium_timeout issue the test which expects a timeout exception is failing , as it should. The test "Should Be Able To Execute Asynchronous Scripts" has not yet been implemented and has been set to fail as a reminder to update it. Finally the test checking the passing of multiple arguments is failing. When I implemented the asynchronous javascript functionality, I merely copied the synchronous javascript keyword which allows for multiple arguments all of which it assumes all is javascript code. But the selenium functions, both asynchronous and synchronous allows for additional arguments. I might correct for that discrepancy later on.

@emanlove
Copy link
Member Author

This issue was fixed and is included in the 1.0.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant