Added class member std::vector<KinBodyPtr> objKinBodyPtrs. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks good. Could you rename the PR from "global variable" to "class member"? |
serna92
changed the title
|
Cross-referencing issue and PR: #33. |
PeterBowman
reviewed
May 23, 2017
There was a problem hiding this comment.
Tested and working 👍. For the sake of completion, I'd update the help command with the corresponding instructions, but it's not crucial.
Update WorldRpcResponder help regarding mk obj as suggested by @PeterBowman at #34 (review)
|
Updated help at 2dea007 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added class member on WorldRPCResponder.h to store kinbodies from generic objects in order to delete them with the
world del allRPC command.WorldRPCResponder modified to be able to add a kinbodies from a xml file with
world mk obj filepathand del them withworld del all.