Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move FakeControlboard to yarp-devices #54

Closed
PeterBowman opened this issue Dec 17, 2017 · 10 comments
Closed

Move FakeControlboard to yarp-devices #54

PeterBowman opened this issue Dec 17, 2017 · 10 comments
Assignees

Comments

@PeterBowman
Copy link
Member

The FakeControlBoard device actually belongs to roboticslab-uc3m/yarp-devices. We only needed this here because of teoSim:

options.put("subdevice","FakeControlboard"); // FakeControlboard provides more interfaces than test_motor

...which is about to die as a result of #27.

When completed, remember to update unit tests at kinematics-dynamics (.travis.yaml + doc/kinematics-dynamics-install.md).

This issue is preceded by 8b4a803 (code & style review, minor refactorization of FCB).

@PeterBowman PeterBowman changed the title Move FakeControlBoard to yarp-devices Move FakeControlboard to yarp-devices Dec 17, 2017
@jgvictores
Copy link
Member

Given that it doesn't even depend on ColorDebug, maybe we could clean it up a bit and try a PR at YARP?

@jgvictores
Copy link
Member

PS: Oh, wait! It does depend on ColorDebug, see here.

@PeterBowman
Copy link
Member Author

PS: Oh, wait! It does depend on ColorDebug, see here.

My bad: 4dfa391 :(. We can revert it, though.

maybe we could clean it up a bit and try a PR at YARP?

For reference: http://yarp.it/classyarp_1_1dev_1_1TestMotor.html.

@traversaro
Copy link

Little intrusion: there is also https://github.com/robotology/yarp/tree/master/src/devices/fakeMotionControl , even if sadly is not greatly documented/visible as most of devices in YARP.

@PeterBowman
Copy link
Member Author

Thanks! I tweaked our unit test at kinematics-dynamics to use fakeMotionControl (in here, passing a compulsory name option as well), but kept being unable to acquire the yarp::dev::IVelocityControl interface handle (crashes here). It does not happen when I upgrade the velocity interface to yarp::dev::IVelocityControl2 (ref).

@jgvictores
Copy link
Member

@traversaro Thanks for the reference!
@PeterBowman Looks good! I put robotology/yarp#1502 just to keep thing in place. :-)

@PeterBowman
Copy link
Member Author

We observed that fakeMotionControl does not emulate velocities in position or velocity control mode.
For now, waiting for #27, and then will move FakeControlboard to yarp-devices.

@jgvictores
Copy link
Member

No longer blocked!

@PeterBowman
Copy link
Member Author

@jgvictores
Copy link
Member

Thank you so much!!

rsantos88 pushed a commit to roboticslab-uc3m/yarp-devices that referenced this issue Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants