Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and Unify Joint Directions of Rotation #39

Closed
jgvictores opened this issue Feb 15, 2018 · 39 comments
Closed

Review and Unify Joint Directions of Rotation #39

jgvictores opened this issue Feb 15, 2018 · 39 comments
Assignees
@jgvictores @rsantos88
Labels
complexity: tedious Tarea tediosa que nadie quiere hacer documentation epic horizontal priority: critical

Comments

@jgvictores
Copy link
Member

Review Joint Directions of Rotation https://github.com/roboticslab-uc3m/teo-developer-manual/blob/master/appendix/a-teo-diagrams.md#joint-directions-of-rotation then unify
@rsantos88 rsantos88 self-assigned this Feb 16, 2018
@rsantos88
Copy link
Contributor

I found that some directions of rotation are wrong.
Do you want to correct the diagram or the direction in the real robot?

@rsantos88
Copy link
Contributor

The signs are ok but, @jmgarciah and me think that the arrows can generate confusin in the Y axis

@jmgarciah
Copy link
Member

Talking with @smcdiaz and seeing the TEO's hardware, we have found a possible solution. Related with the two saggital motor of the legs, the wires of the gear are different from the rest.

@jgvictores have given me permission to change the order of the wires and have the same turning sense that the diagram.

@jmgarciah
Copy link
Member

I have found an image that could be insteresting for a new TEO diagram. And finally understand the joint direction.

imagen1

@jgvictores
Copy link
Member Author

Looks nice, could be done with TEO.

I would try to avoid the RPY terminology (Roll is Z in some fields) and stick to ours.

@jmgarciah
Copy link
Member

I totally agree. It is only an idea. So please, take it as you need

@RaulFdzbis
Copy link
Member

In my opinion, i think that overlapping of the robot model over the axis, make that image a little overload, and can be confusing.

Maybe a good solution could be to use the simplified model that is used now with the Teo Joint Directions of Rotation but with the perspective in that image, for an easier understanding.

@jgvictores
Copy link
Member Author

If anyone could take a picture of TEO in a pose similar to NAO there (same perspective, but arms pointing down), I could give it a shot. Some alpha layer magic should do the trick. :-)

@David-Estevez
Copy link

This is not a picture, but might be useful:
teo

@jmgarciah
Copy link
Member

Something like @David-Estevez shows could be perfect

@David-Estevez
Copy link

I can pose it and change the colors to whatever suits your diagrams, just tell me!

@rsantos88
Copy link
Contributor

@David-Estevez totally agree 👍

@jmgarciah
Copy link
Member

@smcdiaz and me have finished to correct the saggital joint direction. But we have to check that everything is ok

@rsantos88
Copy link
Contributor

@smcdiaz and me have finished to correct the saggital joint direction. But we have to check that everything is ok

I've checked the result with @jmgarciah and it's not working well.
When I run launchLocomotion and check the value of sagital axis, the value is -3.93673706054688
I move this axis to homing position, setting position to 0, and the axis moves outside and when I get the position, it returns -7.45166015625
@jmgarciah propouse to @jgvictores or @smcdiaz to have a look at this problem because
he has no idea.

@rsantos88
Copy link
Contributor

Changed sign of CUI Absolute Encoder to read the correct joint directions of rotation.
See here the changes. It has been tested and it works ok. Now the directions of rotation of the joint ID 5 and 12 correspond to the diagram.

Note: the axial rotation of the waist has not been corrected

@rsantos88
Copy link
Contributor

notes:

  • PR is pending to be performed, but it has been changed on the robot to be use.
  • After all the changes, I've corrected the home position of the legs (more accurate initial position)

@rsantos88
Copy link
Contributor

Other curious note observed:

  • When you run launchLocomotion, always the right sagittal leg moves arround 10º degrees out.
    You can correct this doing the home position with --homePoss, but something causes the joint to move when the driver is initializing.

@jmgarciah
Copy link
Member

The legs' sagittal joints are already fixed. The only remaining joint is the axial waist. Fixing via hardware this joint is more complicate than via software, I think. It is neccesary to separe the body from the legs. I propose to change the values from .ini files. Please @jgvictores , help us.

@jgvictores
Copy link
Member Author

On my way!

@jgvictores
Copy link
Member Author

It is neccesary to separe the body from the legs. I propose to change the values from .ini files

First diagrams, then update all related configuration files and robot models.

@jgvictores
Copy link
Member Author

The fact that there are negative trs in launchLocomotion.ini means that diagrams are incorrect.
I've opened roboticslab-uc3m/teo-configuration-files#11 pointing at the situation.

@rsantos88
Copy link
Contributor

The fact that there are negative trs in launchLocomotion.ini means that diagrams are incorrect.
I've opened roboticslab-uc3m/teo-configuration-files#11 pointing at the situation.

roboticslab-uc3m/teo-configuration-files#11 has been closed.

@rsantos88
Copy link
Contributor

The direction of rotation of the axial waist is opposite in the .ini config file and the diagram.
What we should to change? The diagram? The config file? or it doesn't matter which of them?

@jgvictores
Copy link
Member Author

jgvictores commented Feb 25, 2019 •
edited
Loading

@rsantos88 I've taken a look at roboticslab-uc3m/teo-configuration-files@5addf18 and it seems amazing!

  • To close this issue I'd be satisfied with real TEO's ini files and manual images, and open separate issues on simulation model repositories
  • Note to self: develop small script to enable porting programs to be compatible with new criteria

Issues that will be unblocked:

@rsantos88
Copy link
Contributor

To close this issue I'd be satisfied with real TEO's ini files and manual images, and open separate issues on simulation model repositories

I've modified the images of directions. Review it please: roboticslab-uc3m/teo-developer-manual@6238c4b

In my humble opinion, I think it would be quite interesting to reconsider the revision of the limits. In the arms a more detailed revision of the limits has already been made, correcting some errors. (#15 (comment))
I would work on these limits. Also, I would recommend checking the limits of the legs again with @jmgarciah , and apply the new changes of direction. I await your proposals :)

To continue with this issue, once again, I would recommend modifying and correcting the limits of the arms and legs and then the direction of rotation, are you agree with that?

@jgvictores
Copy link
Member Author

jgvictores commented Mar 15, 2019 •
edited by rsantos88
Loading

Looks great to me!

IMHO, you can close the issue, and we can proceed with:

@rsantos88
Copy link
Contributor

rsantos88 commented Mar 19, 2019 •
edited
Loading

Here are the result of merging the new joint limits of arms with the new direction of rotation in "teo-configuration-files" repository: roboticslab-uc3m/teo-configuration-files#18
(please, check it in case something has escaped me)

Maybe we can keep it this way, without revising the limits of the legs again and consider that the previous measurement with @AlvaroMartinezR was correct. What do you think? Would it be interesting to review the limits of the legs again before continuing?
If we continue without legs revision, the next steps would be:

and...

@jmgarciah
Copy link
Member

I think you should check the whole robot, not just the arms. If we are going to modify the directions of the joints, we should not leave the work halfway.

@rsantos88
Copy link
Contributor

Updated: #39 (comment)

@jgvictores
Copy link
Member Author

Merged at roboticslab-uc3m/yarp-devices@304b245

@jgvictores
Copy link
Member Author

Merged at roboticslab-uc3m/teo-developer-manual@118f472

@jgvictores
Copy link
Member Author

jgvictores commented Mar 27, 2019 •
edited
Loading

Merged at roboticslab-uc3m/teo-configuration-files@23703e1

This was referenced Mar 27, 2019
Closed
Closed
Closed
Open
@jgvictores
Copy link
Member Author

[x] Update demos (or put issue per repo)

Will be tracked at:

@RaulFdzbis RaulFdzbis mentioned this issue Mar 27, 2019
Open
This was referenced Mar 27, 2019
Open
Closed
Open
@rsantos88
Copy link
Contributor

Updated #39 (comment) about update simulated models

@jgvictores
Copy link
Member Author

jgvictores commented Mar 27, 2019 •
edited
Loading

[x] Update simulated models (or put issue per repo)

@rsantos88
Copy link
Contributor

Ok! Can I close this issue or do you want to add more things like the change in kinematics (important issue)?

@jgvictores
Copy link
Member Author

Yes, please close, and we can actually unblock kinematics! Other issues are all tracked individually. 🎉🎉🎉

@jgvictores jgvictores mentioned this issue Apr 8, 2019
Closed
@jgvictores jgvictores added epic and removed blocking Focus on this issue before working on issues that are blocked by it labels May 8, 2019
@jgvictores jgvictores mentioned this issue Oct 3, 2019
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgvictores jgvictores

@rsantos88 rsantos88

Labels
complexity: tedious Tarea tediosa que nadie quiere hacer documentation epic horizontal priority: critical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@David-Estevez @jgvictores @RaulFdzbis @rsantos88 @jmgarciah