Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iCubGenovaV2_5
model (still unsupported but used for internal testing) with a recent sdformat. The new sdformat library does no longer convert urdf to sdf with theuse_parent_model_frame
tag, making the sdf compatible also with pybullet (I didn't test it yet).iCubGenovaV2_5
model as reported also in Investigate color support in mesh files #31 (comment).iCubGenovaV2_5
model.On the long run it would probably make more sense to keep only SDF files. There are a lot of nice features being released that will simplify the robot description. Though, the upcoming controllers will use iDynTree, that supports only URDF. I'd like to reduce the duplication, and since now Gazebo can parse our URDFs without any problem for the time being let's keep only URDFs.
In the future, as soon as the upstream sdf -> urdf conversion will be finalized, we can think of switching back to sdf.