-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract last applied joint forces #141
Extract last applied joint forces #141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, even if I would document that jont_force
is an effort/torque, as a 1 dof force may be surprising for most users.
fe11f29
to
0a80b53
Compare
This goes in the same direction of clearing out in gym-ignition the difference between joint and DoF (#126). Before v1 we have to address it since it could cause misunderstandings. For the time being let's keep this ambiguity and defer the fix to a future PR. |
9fd581b
to
165dc20
Compare
165dc20
to
25d2c52
Compare
25d2c52
to
99a894b
Compare
This PR introduces the support of extracting the last-applied generalized force of joints.
There are few caveats. For instance if physics rate = agent rate = controller rate, everything work as expected. Though, if these rates are different, the extracted force reference could not be what expected. In fact, this method will always return the force reference applied in the last step.
Users should be aware of this behaviour when using this method.
This PR depends on #140.