Check for a compatible Ignition distribution in the system when importing the scenario Python package
#399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoferigo
force-pushed
the
feature/check_version
branch
from
14971d2 to
9c1ab6c
Compare
This was referenced Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often happens that users don't read thoroughly the support policy and install the wrong Ignition distribution. When this happens, importing
scenariofails with arcane error on shared libraries not found.This PR implements a new feature that should provide a more explanatory error message to the users in this case. It covers both cases in which the
igncommand does not exists in PATH (i.e. either Ignition is not installed or the environment is not properly configured) and ifign gazebo --versionsreturns a failing exit code (to be future proof in case the command line changes in next versions).From the python side, we exploit the
packagingpackage.