-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compiling MEX function on Windows #45
Conversation
Then, on @RAR1989 setup, adding to I am not really sure about the |
This error is now blocking the Windows CI for robotology-superbuild, see https://github.com/robotology/robotology-superbuild/pull/296/checks?check_run_id=303624209 . Unfortunately I don't have Windows with Matlab, so I can't test directly this PR, @DanielePucci can we get someone with Windows + Matlab from the lab to test this fix so that we can merge the PR? Thanks! |
As discussed in robotology/robotology-superbuild#226 (comment), unfortunately |
@traversaro there should be Matlab+Windows on the "Monster" (btw, we should find a mapping between acronyms and official IIT names). So @diegoferigo was telling me that he could test the PR next week on it |
Great! |
With Matlab 2019b, this PR is now failing with the following error:
Indeed, this make sense as |
This is not true. The function should be defined by blockfactory/cmake/FindMatlab.cmake Line 1015 in 724c934
|
Ok, that was fun to debug. : )
There was no blockfactory/cmake/FindMatlab.cmake Line 980 in 724c934
mexfilerequiredapiversion .
For some reason, the blockfactory/cmake/FindMatlab.cmake Line 1015 in 724c934
C to the LANGUAGES option of the project CMake function call solved the problem.
This is not the first problem that I have with CMake projects that only decleare |
Related CMake upstream issues and MR: |
I tested the PR with the modified FindMatlab file available in robotology-dependencies/qpOASES#13 , and indeed now the compilation is working fine. Adding the |
As discussed in robotology-dependencies/qpOASES#13 , I suggest to change this PR to use the FindMatlab that will be shipped with CMake 3.16.3, see https://gitlab.kitware.com/cmake/cmake/blob/e6c5bed2aa4ec729dd9d91c056c0147a1f5cd16e/Modules/FindMatlab.cmake . |
CMake 3.16.3 has been released with the fixes of FindMatlab.cmake useful to fix all the Windows linking problems, see https://discourse.cmake.org/t/cmake-3-16-3-available-for-download/530 . |
Replaced by #54 |
Remove workaround for robotology/blockfactory#45
Remove workaround for robotology/blockfactory#45
FindMatlab.cmake
with the latest upstream versionexternal
symbol toconst
. This change has to be tested on Windows.Fixes #44 and robotology/robotology-superbuild#226.