Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not overwrite default linker flags so that LDFLAGS environment variable is considered #63

Merged
merged 3 commits into from
Apr 13, 2021
Merged

Do not overwrite default linker flags so that LDFLAGS environment variable is considered #63

merged 3 commits into from
Apr 13, 2021

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Apr 11, 2021 •
edited
Loading

If one wants to specify additional linked flags, those should be appended to CMAKE_SHARED_LINKER_FLAGS, not overwrite it as this would lead to the LDFLAGS environment variable to be ignored, leading to linking errors in some environments (for example conda).

For more details see:

@traversaro traversaro requested a review from diegoferigo as a code owner April 11, 2021 09:31
@traversaro
Copy link
Member Author

@diegoferigo can we merge?

@diegoferigo diegoferigo merged commit 20871ee into master Apr 13, 2021
@diegoferigo diegoferigo deleted the fix-shared-links branch April 13, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegoferigo diegoferigo diegoferigo approved these changes

Assignees

@traversaro traversaro

Labels
complexity::low component::cmake pr::resolution::merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@traversaro @diegoferigo