-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resetSimulationState and regenerate thrift-generated files #424
Conversation
What is the advantage of resetting the state but not resetting time? |
This is a work-around in order to avoid a problem when resetting the time. If a yarp network wait is running |
Given that we have already |
Ok for me, modulo the small trailing whitespace comment. @diegoferigo any comment? |
Co-Authored-By: triccyx <triccyx@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't go in detail though the code. It seems fine to me as long as you checked:
- Both position and velocity are reset
- The state of the low-level controllers is reset
Just a minor comment, @triccyx it would be easier to review the PR if you commit the autogenerated sources separately.
@traversaro @diegoferigo gentle ping |
Thanks for the PR! |
Reset position to initial pose, do not reset time.