Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable externalwrench plugin if Gazebo version < 8.0 #434

Merged
merged 3 commits into from
Jul 3, 2019
Merged

Disable externalwrench plugin if Gazebo version < 8.0 #434

merged 3 commits into from
Jul 3, 2019

Conversation

gabrielenava
Copy link
Contributor

This fix allow to compile the repo with Gazebo 7. Tested on Ubuntu 16.04 LTS.

@traversaro
Copy link
Member

Can you add an ## [Unreleased] section in https://github.com/robotology/gazebo-yarp-plugins/blob/master/CHANGELOG.md with a Fixed subsection that contains a description and link to this PR? Something like:

## [Unreleased]
### Fixed 
* Fixed compilation on Gazebo 7 by disabling compilation of `externalwrench` plugin if the project is configured with Gazebo 7 (https://github.com/robotology/gazebo-yarp-plugins/pull/434) . 

note that in this project we follow the changelog format discussed in https://keepachangelog.com/en/1.0.0/ .

@gabrielenava
Copy link
Contributor Author

changelog updated.

@traversaro
Copy link
Member

Sorry for bothering, but according to the format described in https://keepachangelog.com/en/1.0.0/, the latest change (including the unreleased one) need to go on the top of the document.

@gabrielenava
Copy link
Contributor Author

changelog fixed

@traversaro traversaro merged commit d748428 into robotology:master Jul 3, 2019
@traversaro
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants