Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions CI #453

Merged
merged 7 commits into from
Nov 17, 2019
Merged

Add GitHub Actions CI #453

merged 7 commits into from
Nov 17, 2019

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Nov 17, 2019

This PR adds a GitHub Actions-based Continuous Integration that can test both in Linux (Ubuntu 18.04) and macOS against configurable multiple version of Gazebo (currently 9 and 10) and YARP currently just the upcoming YARP 3.3 .

Travis failure is unrelated (it is actually related to #442), and Travis will be removed when this PR gets merged.

Fixes #444 .
Fixes #449 .

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor change

cmake -DCMAKE_INSTALL_PREFIX=${GITHUB_WORKSPACE}/install ..
cmake --build . --config ${{ matrix.build_type }} --target install
# YARP
git clone https://github.com/robotology/yarp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add cd ${GITHUB_WORKSPACE} here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed it in 3ec9d8b .

@traversaro traversaro merged commit 0793f34 into devel Nov 17, 2019
@traversaro traversaro deleted the add-ga-ci branch November 17, 2019 19:10
traversaro added a commit that referenced this pull request Nov 17, 2019
Travis is not used anymore, as the CI was migrated to GitHub Actions in #453 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants