Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong install include for gazebo_yarp_lib_common library #644

Merged
merged 2 commits into from
Jan 29, 2023
Merged

Fix wrong install include for gazebo_yarp_lib_common library #644

merged 2 commits into from
Jan 29, 2023

Conversation

traversaro
Copy link
Member

Fix #643

@traversaro traversaro mentioned this pull request Jan 16, 2023
Closed
HosameldinMohamed
HosameldinMohamed approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@HosameldinMohamed HosameldinMohamed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I tested the installed library and the problem no longer exists!

I was searching for INTERFACE_INCLUDE_DIRECTORIES in the source code but couldn't find it!

@HosameldinMohamed
Copy link
Contributor

You may want to update the CHANGELOG too

@traversaro
Copy link
Member Author

Thanks! I tested the installed library and the problem no longer exists!

I was searching for INTERFACE_INCLUDE_DIRECTORIES in the source code but couldn't find it!

That property is probably defined in the GazeboYARPPluginsTargets.cmake file that is generated and installed by CMake. That property is defined indirectly in the code via the target_include_directories(gazebo_yarp_lib_common INTERFACE $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>) calls.

@HosameldinMohamed
Copy link
Contributor

Thanks! I tested the installed library and the problem no longer exists!
I was searching for INTERFACE_INCLUDE_DIRECTORIES in the source code but couldn't find it!

That property is probably defined in the GazeboYARPPluginsTargets.cmake file that is generated and installed by CMake. That property is defined indirectly in the code via the target_include_directories(gazebo_yarp_lib_common INTERFACE $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>) calls.

Great! Thanks!

@traversaro traversaro merged commit 6e2b379 into master Jan 29, 2023
@traversaro traversaro deleted the traversaro-patch-1 branch January 29, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HosameldinMohamed HosameldinMohamed HosameldinMohamed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMake Error when linking GazeboYARPPlugins libraries
2 participants
@traversaro @HosameldinMohamed