Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update models and worlds #114

Merged
merged 7 commits into from
Dec 22, 2019
Merged

Conversation

diegoferigo
Copy link
Member

@diegoferigo diegoferigo commented Dec 20, 2019

  • Remove the sdf file of models that can be imported correctly in Ignition Gazebo from the urdf (CartPole, Pendulum).
  • Convert the iCubGenovaV2_5 model (still unsupported but used for internal testing) with a recent sdformat. The new sdformat library does no longer convert urdf to sdf with the use_parent_model_frame tag, making the sdf compatible also with pybullet (I didn't test it yet).
  • Manually added the material properties to the iCubGenovaV2_5 model as reported also in Investigate color support in mesh files #31 (comment).
  • Removed all the unsupported sensors from iCubGenovaV2_5 model.

On the long run it would probably make more sense to keep only SDF files. There are a lot of nice features being released that will simplify the robot description. Though, the upcoming controllers will use iDynTree, that supports only URDF. I'd like to reduce the duplication, and since now Gazebo can parse our URDFs without any problem for the time being let's keep only URDFs.

In the future, as soon as the upstream sdf -> urdf conversion will be finalized, we can think of switching back to sdf.

@traversaro
Copy link
Member

traversaro commented Dec 22, 2019

  • Convert the iCubGenovaV2_5 model (still unsupported but used for internal testing) with a recent sdformat. The new sdformat library does no longer convert urdf to sdf with the use_parent_model_frame tag, making the sdf compatible also with pybullet (I didn't test it yet).

Related issue: robotology/icub-models#12 .

@traversaro
Copy link
Member

Though, the upcoming controllers will use iDynTree, that supports only URDF. I'd like to reduce the duplication, and since now Gazebo can parse our URDFs without any problem for the time being let's keep only URDFs.

In the future, as soon as the upstream sdf -> urdf conversion will be finalized, we can think of switching back to sdf.

We can also think to switch to sdf only if iDynTree will support loading SDF directly (see robotology/idyntree#481).

@diegoferigo diegoferigo merged commit 5b5bc5f into robotology:devel Dec 22, 2019
@diegoferigo diegoferigo deleted the update_models branch December 22, 2019 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants