Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix controlboard bug on resetPositionsAndTrajectoryGenerators at initial configuration #109

Merged

Conversation

xela-95
Copy link
Member

@xela-95 xela-95 commented Mar 5, 2024

Closes #108

@xela-95 xela-95 self-assigned this Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 55.19%. Comparing base (98f78ae) to head (4617d97).
Report is 1 commits behind head on main.

❗ Current head 4617d97 differs from pull request most recent head c6a3e00. Consider uploading reports for the commit c6a3e00 to get more accurate results

Files Patch % Lines
plugins/controlboard/src/ControlBoard.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   54.65%   55.19%   +0.53%     
==========================================
  Files          26       27       +1     
  Lines        2684     2694      +10     
==========================================
+ Hits         1467     1487      +20     
+ Misses       1217     1207      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@traversaro
Copy link
Member

Do you have any idea why codecov continues to spam messages?

@xela-95
Copy link
Member Author

xela-95 commented Mar 5, 2024

Do you have any idea why codecov continues to spam messages?

unfortunately my updates to the CI yaml were not effective... I think I need to create a separate codecov.yaml file to customize its behavior: https://docs.codecov.com/docs/codecov-yaml

@xela-95
Copy link
Member Author

xela-95 commented Mar 5, 2024

Anyhow it is possible to reproduce the exception I got in #103 (comment) by launching the single pendulum tutorial and by commenting out the <initialConfiguration> block:

<initialConfiguration>0.0</initialConfiguration>

Also here I verified that I had an empty vector as the result of calling:

auto gzPos = gzJoint.Position(ecm).value().at(0);

@xela-95 xela-95 marked this pull request as ready for review March 5, 2024 17:44
@xela-95 xela-95 requested a review from traversaro March 5, 2024 17:44
@xela-95
Copy link
Member Author

xela-95 commented Mar 6, 2024

We're getting (again) a failure in the macos tests, in particular on the new test implemented:
https://github.com/robotology/gz-sim-yarp-plugins/actions/runs/8160658434/job/22307711533?pr=109#step:12:50

 libc++abi: terminating with uncaught exception of type std::__1::system_error: mutex lock failed: Invalid argument

An interesting reference on SO: https://stackoverflow.com/questions/66773247/libcabi-dylib-terminating-with-uncaught-exception-of-type-std-1system-er

@xela-95
Copy link
Member Author

xela-95 commented Mar 6, 2024

We're getting (again) a failure in the macos tests, in particular on the new test implemented: https://github.com/robotology/gz-sim-yarp-plugins/actions/runs/8160658434/job/22307711533?pr=109#step:12:50

 libc++abi: terminating with uncaught exception of type std::__1::system_error: mutex lock failed: Invalid argument

An interesting reference on SO: https://stackoverflow.com/questions/66773247/libcabi-dylib-terminating-with-uncaught-exception-of-type-std-1system-er

Also this could be related to the bug #102, since different platforms I'mplement locking mechanisms in different ways, this problem maybe shows up only on macOs...

@xela-95 xela-95 force-pushed the fix/resetpositionsandtrajectorygenerators-at-configure-time branch from 4617d97 to c6a3e00 Compare March 6, 2024 10:21
@xela-95
Copy link
Member Author

xela-95 commented Mar 6, 2024

Since this macOS issue is not related to the current development and is already documented in #90, I will exclude the new test from it for the time being.

@xela-95
Copy link
Member Author

xela-95 commented Mar 6, 2024

Test passed! Merging 🚀

@xela-95 xela-95 merged commit 0d687f7 into main Mar 6, 2024
7 checks passed
@xela-95 xela-95 deleted the fix/resetpositionsandtrajectorygenerators-at-configure-time branch March 6, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix controlboard bug on resetPositionsAndTrajectoryGenerators at initial configuration
2 participants