-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix controlboard bug on resetPositionsAndTrajectoryGenerators at initial configuration #109
Fix controlboard bug on resetPositionsAndTrajectoryGenerators at initial configuration #109
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
+ Coverage 54.65% 55.19% +0.53%
==========================================
Files 26 27 +1
Lines 2684 2694 +10
==========================================
+ Hits 1467 1487 +20
+ Misses 1217 1207 -10 ☔ View full report in Codecov by Sentry. |
Do you have any idea why codecov continues to spam messages? |
unfortunately my updates to the CI yaml were not effective... I think I need to create a separate |
Anyhow it is possible to reproduce the exception I got in #103 (comment) by launching the single pendulum tutorial and by commenting out the
Also here I verified that I had an empty vector as the result of calling:
|
We're getting (again) a failure in the macos tests, in particular on the new test implemented:
An interesting reference on SO: https://stackoverflow.com/questions/66773247/libcabi-dylib-terminating-with-uncaught-exception-of-type-std-1system-er |
Also this could be related to the bug #102, since different platforms I'mplement locking mechanisms in different ways, this problem maybe shows up only on macOs... |
…p when no initial configuration is provided
4617d97
to
c6a3e00
Compare
Since this macOS issue is not related to the current development and is already documented in #90, I will exclude the new test from it for the time being. |
Test passed! Merging 🚀 |
Closes #108