Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup gz-sim-yarp-plugins-check-model tests #204

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Aug 23, 2024

  • Fix ENVIRONMENT and ENVIRONMENT_MODIFICATION arguments to work on Windows
  • Uncomment tests that were failing
  • Fix URI of laser.ini in laser tutorial (that was not an URI before)

@traversaro traversaro requested a review from xela-95 August 23, 2024 15:08
@traversaro
Copy link
Member Author

Great, now all the test pass!

Copy link
Member

@xela-95 xela-95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @traversaro, it LGTM

Thanks also to have spotted the missing URI on the laser test that I missed in #176

* Fix `ENVIRONMENT` and `ENVIRONMENT_MODIFICATION` arguments to work on Windows
* Uncomment tests that were failing
@xela-95 xela-95 force-pushed the traversaro-patch-9 branch from fdc189b to 9b7967d Compare August 29, 2024 13:13
@xela-95
Copy link
Member

xela-95 commented Aug 29, 2024

Rebased on main.

@xela-95
Copy link
Member

xela-95 commented Aug 29, 2024

Merging 🚀

@xela-95 xela-95 merged commit cd11e28 into main Aug 29, 2024
5 checks passed
@xela-95 xela-95 deleted the traversaro-patch-9 branch August 29, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants