Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github workflow to automatically update pixi lockfile #207

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

xela-95
Copy link
Member

@xela-95 xela-95 commented Sep 3, 2024

In this way, we do not risk forgetting to maintain the Pixi lock files.

The action comes from the official documentation: https://pixi.sh/dev/advanced/updates_github_actions/#how-to-use with some customizations done by @flferretti in ami-iit/jaxsim#221

Remark: as specified in the documentation, the permission of the repo should be set as follows:
image

@xela-95 xela-95 added the CI Issues regarding CI workflows label Sep 3, 2024
@xela-95 xela-95 self-assigned this Sep 3, 2024
@xela-95 xela-95 requested a review from traversaro September 5, 2024 15:22
@xela-95 xela-95 marked this pull request as ready for review September 5, 2024 15:23
@xela-95 xela-95 force-pushed the ci/add-pixi-workflow branch from e2d925f to 3445e0a Compare September 5, 2024 16:05
@xela-95
Copy link
Member Author

xela-95 commented Sep 5, 2024

Triggered the action on my fork of the repository since the action is only available when on main: https://github.com/xela-95/gz-sim-yarp-plugins/actions/runs/10724133024

@xela-95
Copy link
Member Author

xela-95 commented Sep 5, 2024

Triggered the action on my fork of the repository since the action is only available when on main: https://github.com/xela-95/gz-sim-yarp-plugins/actions/runs/10724133024

It executed successfully and it generated the PR: xela-95#1

@traversaro
Copy link
Member

I am not enthusiastic of the idea of the automatic pixi-lock update (for the reasons described in robotology/whole-body-estimators#191), but if it is happening only one a month that is ok for me.

@xela-95
Copy link
Member Author

xela-95 commented Sep 5, 2024

I am not enthusiastic of the idea of the automatic pixi-lock update (for the reasons described in robotology/whole-body-estimators#191), but if it is happening only one a month that is ok for me.

Thanks for linking the discussion, I've not considered that side-effect, maybe we could track the pixi lockfile with LFS or maybe only maintain the the manual worflow-dispatch way of running the action.

@traversaro
Copy link
Member

I think we can try the automatic update for some time and then monitor the size of the repo. If it increases too much, we can switch to manual sporadic updates.

@xela-95
Copy link
Member Author

xela-95 commented Sep 5, 2024

Perfect! Merging 🚀

@xela-95 xela-95 merged commit 0956c6d into main Sep 5, 2024
5 checks passed
@xela-95 xela-95 deleted the ci/add-pixi-workflow branch September 5, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Issues regarding CI workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants