Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apt CI: Increase until-pass number to mitigate Camera test flakiness #76

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Jan 29, 2024

See #75 . In general, it is better not to have red CI, otherwise they may hide valid regressions. So if some failure are know, better to suppress them rather then just keep a red CI.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4a0ff1d) 83.31% compared to head (14f60e9) 83.31%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #76   +/-   ##
=======================================
  Coverage   83.31%   83.31%           
=======================================
  Files          16       16           
  Lines        1001     1001           
=======================================
  Hits          834      834           
  Misses        167      167           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@traversaro traversaro requested a review from xela-95 January 29, 2024 15:36
@xela-95
Copy link
Member

xela-95 commented Jan 29, 2024

Yes I agree, thanks @traversaro

@traversaro
Copy link
Member Author

Feel free to merge, thanks!

@xela-95
Copy link
Member

xela-95 commented Jan 29, 2024

Feel free to merge, thanks!

Ok! Closes #75

@xela-95 xela-95 merged commit db0f2fe into main Jan 29, 2024
7 checks passed
@traversaro traversaro deleted the traversaro-patch-8 branch January 29, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants