Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve problem of pairing the (fake) links in human state provider #96

Closed
kouroshD opened this issue Feb 21, 2019 · 2 comments
Closed

Comments

@kouroshD
Copy link
Contributor

Trying to make pairs between the fake links introduced here , we noticed that it it can't make correctly the pairs, for all links. Investigating more, on the code of the human state provider in function static void createEndEffectorsPairs we understood that it guarantees that it will find a pair, but it could not guarantee the minimum distance neighborhood (at least) in the case of adding the fake links. Therefore, we modified the code , such that now it can find minimum distance link pairs (but still I can not guarantee that it always find the minimum distance pair of the links). In any case, I suggest later, we can merge this commit, as it have better performance and more predictable output.

@yeshasvitirupachuri
Copy link
Member

Also, we need to update the function name from createEndEffectorsPairs to something like createLinkPairs

@kouroshD
Copy link
Contributor Author

Since we have found and resolved the problem as mentioned in the first comment, I close this issue.

traversaro pushed a commit that referenced this issue Sep 23, 2024
* update README.md with dependencies and compilation

* Update README.md

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants