Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CoM info as the output of HumanStateProvider #121

Merged
merged 5 commits into from
Jun 5, 2019

Conversation

kouroshD
Copy link
Contributor

The changes have been tested using offline dumped data.

@yeshasvitirupachuri
Copy link
Member

LGTM 👍

@lrapetti if you agree, we can merge it upstream. Let me know.

@yeshasvitirupachuri
Copy link
Member

yeshasvitirupachuri commented Jun 3, 2019

@diegoferigo I think I do not have access to Codacy settings on the branches.
Please double check that and enable it for the branch this PR is open to.
Also, I think we need to update the CI steps to consider the latest changes on wearables too.
Thanks.

@traversaro
Copy link
Member

Also, I think we need to update the CI steps to consider the latest changes on wearables too.

The error is:

Cloning into 'wearables'...
error: pathspec 'feature/cleanup' did not match any file(s) known to git.
The command "docker exec testContainer ./.ci/build_deps.sh" failed and exited with 1 during . 

I guess it should be sufficient to remove/change the line in https://github.com/robotology/human-dynamics-estimation/blob/integration_based_teleoperation/.ci/build_deps.sh#L71 .

@lrapetti
Copy link
Member

lrapetti commented Jun 3, 2019

Also, I think we need to update the CI steps to consider the latest changes on wearables too.

The error is:

Cloning into 'wearables'...
error: pathspec 'feature/cleanup' did not match any file(s) known to git.
The command "docker exec testContainer ./.ci/build_deps.sh" failed and exited with 1 during . 

I guess it should be sufficient to remove/change the line in https://github.com/robotology/human-dynamics-estimation/blob/integration_based_teleoperation/.ci/build_deps.sh#L71 .

It has to be changed with feature/ICub-device-impl. @kouroshD can you please add this change to the PR?

@traversaro
Copy link
Member

It has to be changed with feature/ICub-device-impl. @kouroshD can you please add this change to the PR?

Alternatively, you can just fix it with a PR on the target branch integration_based_teleoperation (that looks a lot like a devel branch :D ), and then rebase all the PRs.

@kouroshD
Copy link
Contributor Author

kouroshD commented Jun 3, 2019

Also, I think we need to update the CI steps to consider the latest changes on wearables too.

The error is:

Cloning into 'wearables'...
error: pathspec 'feature/cleanup' did not match any file(s) known to git.
The command "docker exec testContainer ./.ci/build_deps.sh" failed and exited with 1 during . 

I guess it should be sufficient to remove/change the line in https://github.com/robotology/human-dynamics-estimation/blob/integration_based_teleoperation/.ci/build_deps.sh#L71 .

It has to be changed with feature/ICub-device-impl. @kouroshD can you please add this change to the PR?

done!

@yeshasvitirupachuri
Copy link
Member

Also, I think we need to update the CI steps to consider the latest changes on wearables too.

The error is:

Cloning into 'wearables'...
error: pathspec 'feature/cleanup' did not match any file(s) known to git.
The command "docker exec testContainer ./.ci/build_deps.sh" failed and exited with 1 during . 

I guess it should be sufficient to remove/change the line in https://github.com/robotology/human-dynamics-estimation/blob/integration_based_teleoperation/.ci/build_deps.sh#L71 .

It has to be changed with feature/ICub-device-impl. @kouroshD can you please add this change to the PR?

@lrapetti why feature/ICub-device-impl branch? master branch of wearables is stable to use right ?

@kouroshD
Copy link
Contributor Author

kouroshD commented Jun 4, 2019

Also, I think we need to update the CI steps to consider the latest changes on wearables too.

The error is:

Cloning into 'wearables'...
error: pathspec 'feature/cleanup' did not match any file(s) known to git.
The command "docker exec testContainer ./.ci/build_deps.sh" failed and exited with 1 during . 

I guess it should be sufficient to remove/change the line in https://github.com/robotology/human-dynamics-estimation/blob/integration_based_teleoperation/.ci/build_deps.sh#L71 .

It has to be changed with feature/ICub-device-impl. @kouroshD can you please add this change to the PR?

@lrapetti why feature/ICub-device-impl branch? master branch of wearables is stable to use right ?

Cuurently, the integration_based_teleoperation branch of HDE is compatible with feature/ICub-device-impl of wearables. If I am not wrog the same applies for the master branch of HDe as well.

@kouroshD
Copy link
Contributor Author

kouroshD commented Jun 4, 2019

@lrapetti If everything is fine, please follow with merging.

@lrapetti
Copy link
Member

lrapetti commented Jun 4, 2019

@lrapetti If everything is fine, please follow with merging.

Thanks @kouroshD
Let's wait for the checks and then I will merge it

@lrapetti
Copy link
Member

lrapetti commented Jun 5, 2019

The check for ubuntu 18.04 passed, while Travis failed for Ubuntu 16.04 that is not meant to be supported for HDE (I will provide removing the tests).
Apveyor instead has been broken for long time, and it can be removed for the moment.
I will procede with merging then.

@lrapetti lrapetti merged commit c6bb792 into integration_based_teleoperation Jun 5, 2019
@lrapetti lrapetti deleted the feature/addCoM branch June 5, 2019 10:13
@lrapetti
Copy link
Member

lrapetti commented Jun 5, 2019

integration_based_teleoperation has been moved to a new devel branch

@lrapetti lrapetti mentioned this pull request Jun 10, 2019
traversaro pushed a commit that referenced this pull request Sep 23, 2024
add Haptic Sense Glove Wearable implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants