Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update battery hex naming convention #120

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Update battery hex naming convention #120

merged 2 commits into from
Dec 4, 2023

Conversation

MSECode
Copy link
Contributor

@MSECode MSECode commented Dec 1, 2023 •
edited by valegagge
Loading

This is related to the changes explained at this issue: robotology/icub-firmware#443

So now the 2 executable for the BAT fw are bat.r1.hex and bat.hex, which has been modified from bat.icub3.hex that had a misleading name considering it is used on both iCub (all version provided with BAT) and ergoCub

Error is related to this issue: #115

@MSECode MSECode self-assigned this Dec 1, 2023
@valegagge valegagge mentioned this pull request Dec 1, 2023
Closed
valegagge
valegagge approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@valegagge valegagge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

valegagge
valegagge approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@valegagge valegagge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

marcoaccame
marcoaccame approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks

@marcoaccame marcoaccame merged commit 7bca25e into robotology:devel Dec 4, 2023
@MSECode MSECode deleted the fix/batteryVersion branch March 21, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoaccame marcoaccame marcoaccame approved these changes

@valegagge valegagge valegagge approved these changes

Assignees

@MSECode MSECode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MSECode @valegagge @marcoaccame