Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update firmware.info.xml with 2foc ver 3.3.26 #136

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

MSECode
Copy link
Contributor

@MSECode MSECode commented Feb 14, 2024

This PR brings the following changes - As define for robotology/icub-firmware#466:

  • PWM frequency reduced from 40 kHz to 20 kHz
  • Improving of the management of errors conditions in the temperature reading:
    • as described in the documentation different negative temperatures are sent to the user for showing different error conditions
    • at each error in the TDB where we are loosing the correct configuration of the board we are calling its re-configuration
    • temperature sent over CAN towards the EMS in the moment the reading is done
    • reading is now at 100 ms
    • if motor stays in overtemperature for more than 10 consecutive seconds we are putting the joint in fault, otherwise we just send warnings
    • if we cannot read from the TDB for more than 10 consecutive seconds we are putting the joint in fault, otherwise we try to reconfigure the sensor
    • the overheating error is removed when the read temperature is just less than the given threshold
  • introduced a methods (never called) for generating synthetic temperature data
  • now the default value for the stator-rotor offset is not 0x0000 but is 0xFFFF

@MSECode MSECode requested a review from valegagge February 14, 2024 12:47
@MSECode MSECode self-assigned this Feb 14, 2024
@valegagge valegagge merged commit 63ce96d into robotology:devel Feb 14, 2024
Copy link
Member

@valegagge valegagge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valegagge
Copy link
Member

cc @marcoaccame @ale-git

@MSECode MSECode deleted the fix/temperatureReading branch March 21, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants