Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update amc v2.1, ems v3.86, mc4plus v3.89, mc2plus v3.68 #145

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Update amc v2.1, ems v3.86, mc4plus v3.89, mc2plus v3.68 #145

merged 1 commit into from
Mar 15, 2024

Conversation

MSECode
Copy link
Contributor

@MSECode MSECode commented Mar 15, 2024 •
edited
Loading

Updates:

  • Updates for generic error translation from bits to string using this method motorStatusBitsToString()
  • Move eOmc_motorFaultState_t to EoMotionControl in order that we can use same type on both fw and sw
  • Then add the enum typedef eOmc_motorFaultState_numberof as guard to array dimension

Related to robotology/icub-main#942 and robotology/icub-firmware#486

@MSECode MSECode self-assigned this Mar 15, 2024
marcoaccame
marcoaccame approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks.

@MSECode MSECode marked this pull request as draft March 15, 2024 14:37
@MSECode MSECode marked this pull request as draft March 15, 2024 14:37
@MSECode MSECode mentioned this pull request Mar 15, 2024
Merged
@MSECode MSECode marked this pull request as ready for review March 15, 2024 16:02
@MSECode MSECode requested a review from marcoaccame March 15, 2024 16:04
marcoaccame
marcoaccame approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks

@marcoaccame marcoaccame merged commit fb6d215 into robotology:devel Mar 15, 2024
@MSECode MSECode deleted the fix/diagnosticGenError branch March 21, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoaccame marcoaccame marcoaccame approved these changes

@valegagge valegagge Awaiting requested review from valegagge

Assignees

@MSECode MSECode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MSECode @marcoaccame