Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BAT to version 1.2.1 for fix on V_BATTERY values #93

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Update BAT to version 1.2.1 for fix on V_BATTERY values #93

merged 1 commit into from
Jul 12, 2023

Conversation

MSECode
Copy link
Contributor

@MSECode MSECode commented Jul 11, 2023

Update version w/ fix on battery voltage and charge

@MSECode
Update BAT to version 1.2.1 for fix on V_BATTERY values
714d180 
Update version w/ fix on battery voltage and charge
@MSECode MSECode requested review from MrAndrea and valegagge July 11, 2023 10:34
@MSECode MSECode marked this pull request as draft July 11, 2023 10:34
MrAndrea
MrAndrea approved these changes Jul 11, 2023
View reviewed changes
Copy link

@MrAndrea MrAndrea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@MSECode
Copy link
Contributor Author

MSECode commented Jul 12, 2023

Tested BAT on R1 SN003
Here follows the reading of the port /cer/battery/data:o
image

@MSECode MSECode marked this pull request as ready for review July 12, 2023 15:08
@MSECode
Copy link
Contributor Author

MSECode commented Jul 12, 2023

Firmware flashed on the BAT board already attached to the robot.
Ready for the merge

@MSECode MSECode self-assigned this Jul 12, 2023
valegagge
valegagge approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@valegagge valegagge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valegagge valegagge merged commit 681e22e into robotology:devel Jul 12, 2023
@MSECode MSECode deleted the fix/batteryCharge branch July 12, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAndrea MrAndrea MrAndrea approved these changes

@valegagge valegagge valegagge approved these changes

Assignees

@MSECode MSECode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MSECode @valegagge @MrAndrea