-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling of overcurrent flag #83
Conversation
/remind tomorrow |
⏰ Reminder |
Hi @pattacini, I'm going to test this features in the next few hours , stay tuned! 📢 cc @Nicogene |
Hi @pattacini, Here are the results promised: yarpmotorgui_teY1F2z47a.mp4I tested the new <param name="motorNominalCurrents"> 30 </param>
<param name="motorPeakCurrents"> 40 </param>
<param name="motorOverloadCurrents"> 50 </param> I also tested succefully the same A new PR on |
Thanks heaps! |
- update codegen w/ changes did in robotology/icub-firmware-models#83
I'll address the change asap on the WIP version of the new architectural model. |
This PR addresses #58 by adding up the transmission of the overcurrent flag via CAN.
Here's a list of things I did:
🔘 Updated
Flags
in the dictionary🔘 Updated
SupervisorRX
FSM🔘 Updated
SupervisorTX/MSG_STATUS_HANDLER
FSM🔘 Updated
CAN_Encoder/STATUS/format_status_pck
function📝 AOB
Warning
I also had to update some test models (see the tab Files changed) to comply with the changes in the dictionary.
Note
@mfussi66, we're required to port these modifications to the new architectural model.
⚙️ Tests
Important
The changes need to be tested!
cc @valegagge @Nicogene @mfussi66 @sgiraz