Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calibration type 14 update and refactoring #83

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

MSECode
Copy link
Contributor

@MSECode MSECode commented Jun 5, 2023

Update POS service and correlated methods for new calibration type 14 improvement

Specifically, important changes to check are the following:

  • addition of the typedef struct eOmap_int32_u08_t used to map rotation values in int32_t with the ones in uint8_t used by the enum defined in the POS service
  • definition of the static array s_eomc_map_of_calib14rot used for keeping the available values accepted for the rotation parameter
  • definition of the method eomc_int2calib14_ROT used for performing the conversion from int32_t and uint8_t specific data type and inverse method eomc_calib14_ROT2int to convert a value of type eOmc_calib14_ROT_t to int32_t
  • fix values of struct eOmc_calibrator_params_type14_qenc_hard_stop_and_fap_t by setting data type int32_t for rotation which is not treated as uint8_t by that struct and then re-defined the filler bits for keeping standard ordered groups of data of 32bit each
  • improve version defined in CMakeLists.txt to 1.34.3

@CLAassistant
Copy link

CLAassistant commented Jun 5, 2023

CLA assistant check
All committers have signed the CLA.

@valegagge
Copy link
Member

Hi @MSECode ,
I gave a look at your code and I think it is correct to put the map for the conversion of rotor parameter in the motion control file.

I'll complete the review tomorrow after the changes we discussed before.

Add enum and map to convert int32 to enum rotation
Remove const from value passed to int2enum conversion method for FAP rotation
Increase to version 1.34.3
Add method for converting also int 2 enum for eOmc_calib14_ROT_t
Fix rotation type from uint8_t to int32_t + filler to 32bit in eOmc_calibrator_params_type14_qenc_hard_stop_and_fap_t
@MSECode MSECode force-pushed the feature/calib14 branch from 3da7438 to 257425a Compare June 9, 2023 11:49
Copy link
Member

@valegagge valegagge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done!!!

@valegagge valegagge merged commit b549dee into robotology:devel Jun 9, 2023
@MSECode MSECode deleted the feature/calib14 branch June 9, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants