Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix s_mn_servicecategory_strings array #92

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Fix s_mn_servicecategory_strings array #92

merged 2 commits into from
Feb 23, 2024

Conversation

MSECode
Copy link
Contributor

@MSECode MSECode commented Feb 16, 2024

Update:

  • fix map array for service category
  • Now the correct service category is printed in YRI

@MSECode
Fix s_mn_servicecategory_strings array
7796c8e 
Now the correct service category is printed in YRI
@MSECode MSECode self-assigned this Feb 16, 2024
@MSECode MSECode marked this pull request as draft February 16, 2024 09:54
@MSECode MSECode mentioned this pull request Feb 16, 2024
Closed
@pattacini pattacini mentioned this pull request Feb 16, 2024
Merged
@valegagge
Copy link
Member

Hi @MSECode,
this PR is fine for me. I'm going to wait for the tests before reviewing.

valegagge
valegagge approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@valegagge valegagge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@valegagge valegagge marked this pull request as ready for review February 21, 2024 13:27
@valegagge valegagge marked this pull request as draft February 21, 2024 14:43
@valegagge valegagge marked this pull request as ready for review February 21, 2024 21:06
marcoaccame
marcoaccame approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks

@MSECode MSECode mentioned this pull request Feb 23, 2024
Merged
@marcoaccame marcoaccame merged commit 4efc4f4 into robotology:devel Feb 23, 2024
2 checks passed
@MSECode MSECode deleted the fix/diagnosticLostCANBoards branch March 6, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoaccame marcoaccame marcoaccame approved these changes

@valegagge valegagge valegagge approved these changes

Assignees

@MSECode MSECode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MSECode @valegagge @marcoaccame