Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump C++ version used in embot to C++17 #98

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

traversaro
Copy link
Member

#97 added a nested namespace (https://en.cppreference.com/w/cpp/language/namespace) to embot headers, that is a feature available only in C++17 . Recent versions of gcc and clang default to use C++17 so this is not a problem, while trying to compile the file in Visual Studio results in an error:

2024-10-01T03:15:18.9723412Z D:\a\robotology-superbuild\robotology-superbuild\src\icub_firmware_shared\embot\core\embot_core_binary.h(288,11): error C2429: language feature 'nested-namespace-definition' requires compiler flag '/std:c++17' [D:\a\robotology-superbuild\robotology-superbuild\b\src\icub_firmware_shared\embot\embot.vcxproj] [D:\a\robotology-superbuild\robotology-superbuild\b\icub_firmware_shared.vcxproj]

see https://github.com/robotology/robotology-superbuild/actions/runs/11117493180/job/30889518253 .

This PR fixes the compilation error by bumping the C++ standard version used from C++14 to C++17 .

@traversaro
Copy link
Member Author

Apparently the CI in https://github.com/robotology/icub-firmware-shared/actions/workflows/ci.yml was disabled, I just re-enabled it.

@traversaro traversaro closed this Oct 1, 2024
@traversaro traversaro reopened this Oct 1, 2024
@traversaro
Copy link
Member Author

fyi @marcoaccame

@marcoaccame marcoaccame merged commit 67c6b9a into robotology:devel Oct 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants