Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMC2C: Add embot_app_board_amc2c_test #375

Merged
merged 1 commit into from
Apr 28, 2023
Merged

AMC2C: Add embot_app_board_amc2c_test #375

merged 1 commit into from
Apr 28, 2023

Conversation

sgiraz
Copy link
Contributor

@sgiraz sgiraz commented Apr 27, 2023

What's new:

  • Add a new embot_app_board_amc2c_test test file
  • Add test for:
    • hall sensors
    • encoder reading
    • adc currents reading

Note

  • The changes on this PR involve only the AMC board for the 2nd core.

@sgiraz sgiraz requested a review from marcoaccame April 27, 2023 19:27
@sgiraz sgiraz self-assigned this Apr 27, 2023
marcoaccame
marcoaccame approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks

@marcoaccame marcoaccame merged commit da8cefc into robotology:devel Apr 28, 2023
valegagge pushed a commit to valegagge/icub-firmware that referenced this pull request May 5, 2023
@sgiraz @valegagge
AMC2C: Add embot_app_board_amc2c_test (robotology#375)
a02f3a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoaccame marcoaccame marcoaccame approved these changes

Assignees

@sgiraz sgiraz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgiraz @marcoaccame