Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer embot::hw::motor + motorhal for board amc2c #376

Merged
merged 5 commits into from
May 3, 2023
Merged

Layer embot::hw::motor + motorhal for board amc2c #376

merged 5 commits into from
May 3, 2023

Conversation

marcoaccame
Copy link
Contributor

@marcoaccame marcoaccame commented May 3, 2023

This PR adds in embot::hw::motor for the amc2c board all that is required to drive the motor with the MBD code.

This code guarantees the legacy HW tests of previous PR.

Some extra basic tests are done (e.g., the calibration mechanism of the ADC acquisition) so we are ready for the tests on the motor w/ MBD.

@marcoaccame marcoaccame marked this pull request as draft May 3, 2023 11:05
@sgiraz
Copy link
Contributor

sgiraz commented May 3, 2023

Hi @marcoaccame, I'm going to do this test right now.

@marcoaccame marcoaccame marked this pull request as ready for review May 3, 2023 13:22
@marcoaccame marcoaccame merged commit 5a3b9da into robotology:devel May 3, 2023
valegagge pushed a commit to valegagge/icub-firmware that referenced this pull request May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants