Cleanup of MC: removed code for old management of 7 joints in handv3 #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up code under the macro
EOTHESERVICES_customize_handV3_7jointsthat is not used anymore.Description
The code under the
EOTHESERVICES_customize_handV3_7jointsmacro was added some time ago to allow the management of 7 joints inside theMControlleras required by the first iteration of the V3 hand which used 4 motors actuated locally by themc4plusplus 3 piezo electric motors actuated over CAN by thepmcboard.But now this solution has been dropped and the code under the macro is not needed anymore. So, we can safely remove it as it just adds noise.
This PR removes it.
It is not required to produce new binaries for now because no new feature is really added. Moreover, imminent PRs will come that require new binaries, so we can wait for them.
Mergeability
The PR just removes not compiled dead code. Nevertheless a binary for the
mc4plushas been tested on a dedicated setup and everything works fine, so we can safely merge.