Fix on all Diagnostic error #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add mspassed to State::justLOST Fix errors with service category passed, time from last contact and can mapping in canmonitor errors Fix Config constexpr, Initialize boards2report as boards2touch periodofreport params not updated to prv var boards2report now initialized to zero as for boards2touch instead of to be re-initialized at each CANmonitor.tick() call initially set as _config.target and cleaned at CANmonitor.stop() Now the diagnostic maps are filled correctly. Clean boads2report when inside the check and reset periodofreport to 10 sec
|
Hi @MSECode, |
valegagge
approved these changes
Feb 21, 2024
|
need to update new versions of the fw to have the build aligned |
|
Need to update the new fw versions for the boards so that they are aligned with the build |
marcoaccame
reviewed
Feb 23, 2024
emBODY/eBcode/arch-arm/board/ems004/appl/v2/src/eoappservices/embot_app_eth_CANmonitor.h
Show resolved
Hide resolved
emBODY/eBcode/arch-arm/board/ems004/appl/v2/src/eoappservices/embot_app_eth_CANmonitor.cpp
Show resolved
Hide resolved
emBODY/eBcode/arch-arm/board/ems004/appl/v2/src/eoappservices/embot_app_eth_CANmonitor.cpp
Show resolved
Hide resolved
MSECode
force-pushed
the
fix/diagnosticLostCANBoards
branch
from
14aa0f9 to
3fa8b83
Compare
marcoaccame
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mspassed to State::justLOST
Fix errors with service category passed, time from last contact and can mapping in canmonitor errors Fix Config constexpr, Initialize boards2report as boards2touch periodofreport params not updated to prv var
boards2report now initialized to zero as for boards2touch instead of to be re-initialized at each CANmonitor.tick() call initially set as _config.target and cleaned at CANmonitor.stop()
Now the diagnostic maps are filled correctly.
Clean boads2report when inside the check and reset periodofreport to 10 sec.
Report all fixes: