Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This PR fixes the wrist mk2 get position reference bug. #522

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

ale-git
Copy link
Contributor

@ale-git ale-git commented Oct 2, 2024

As per title.

ale-git added a commit to ale-git/icub-firmware-build that referenced this pull request Oct 22, 2024
Built from robotology/icub-firmware#522

It fixes the wrist mk2 setpoint feedback bug.
@pattacini
Copy link
Member

Needs to be tested, please don't merge yet.

Tested successfully in icub-tech-iit/ergocub-software#261 (comment).

I think we can merge the PR, @ale-git @marcoaccame

@pattacini pattacini requested a review from marcoaccame October 25, 2024 12:22
@pattacini
Copy link
Member

Well, there are conflicts to solve first, @ale-git.

@ale-git ale-git marked this pull request as ready for review October 31, 2024 12:35
Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok @ale-git, the PR is fine. Pls just edit the description and then I will merge.

@marcoaccame marcoaccame merged commit 5ff3228 into robotology:devel Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants