Add note for commented lines and removed useless stuff

robotology · Oct 1, 2024 · f45ae6f · f45ae6f
1 parent f3f2fe1
commit f45ae6f
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 9 deletions.
diff --git a/app/motorTemperaturePublisher/conf/config.ini b/app/motorTemperaturePublisher/conf/config.ini
@@ -1,5 +1,5 @@
 [GENERAL]
-robotname         ergocub2S
+robotname         ergocub
 period            1.0
-portprefix        /upper_arm
-listofjoints      (0 1 )
+portprefix        /left_leg
+listofjoints      (0 1 2 3 4 5)
diff --git a/src/libraries/CMakeLists.txt b/src/libraries/CMakeLists.txt
@@ -42,4 +42,3 @@ if(ICUB_USE_IPOPT)
 else()
   message(STATUS "IPOPT not found/selected, skipping optimization")
 endif()
-
diff --git a/src/libraries/icubmod/embObjMotionControl/embObjMotionControl.cpp b/src/libraries/icubmod/embObjMotionControl/embObjMotionControl.cpp
@@ -141,10 +141,7 @@ bool embObjMotionControl::alloc(int nj)
         _temperatureExceededLimitWatchdog.at(i).setThreshold(txrate);
         _temperatureSensorErrorWatchdog.at(i).setThreshold(txrate);
     }
-
-    //TODO:call private method for populating keys for map of raw values data??
-    // should we populate map at the beginning with key and resizing the vectors ??
-    // do wee just use vectors and forget about the map at this level ??
+
     return true;
 }
 

diff --git a/src/libraries/icubmod/embObjMotionControl/embObjMotionControl.h b/src/libraries/icubmod/embObjMotionControl/embObjMotionControl.h
@@ -349,7 +349,6 @@ class yarp::dev::embObjMotionControl:   public DeviceDriver,
     std::vector<yarp::dev::eomc::TemperatureFilter> _temperatureSpikesFilter;
 
     std::map<std::string, rawValuesKeyMetadata> _rawValuesMetadataMap;
-    //std::map<std::string, std::int32_t> _rawValuesKeysVsizeMap;
     std::vector<std::int32_t> _rawDataAuxVector;
     int sawthootTestVal;
 

diff --git a/src/libraries/icubmod/fakeRawValuesPublisher/FakeRawValuesPublisher_ParamsParser.h b/src/libraries/icubmod/fakeRawValuesPublisher/FakeRawValuesPublisher_ParamsParser.h
@@ -14,6 +14,7 @@
 #ifndef FAKERAWVALUESPUBLISHER_PARAMSPARSER_H
 #define FAKERAWVALUESPUBLISHER_PARAMSPARSER_H
 
+// NOTE: commented code is kept to let device running with yarp 3.9. They can be removed when 3.10 available
 #include <yarp/os/Searchable.h>
 //#include <yarp/dev/IDeviceDriverParams.h>
 #include <string>

diff --git a/src/libraries/icubmod/rawValuesPublisherClient/RawValuesPublisherClient_ParamsParser.h b/src/libraries/icubmod/rawValuesPublisherClient/RawValuesPublisherClient_ParamsParser.h
@@ -14,6 +14,7 @@
 #ifndef RAWVALUESPUBLISHERCLIENT_PARAMSPARSER_H
 #define RAWVALUESPUBLISHERCLIENT_PARAMSPARSER_H
 
+// NOTE: commented code is kept to let device running with yarp 3.9. They can be removed when 3.10 available
 #include <yarp/os/Searchable.h>
 //#include <yarp/dev/IDeviceDriverParams.h>
 #include <string>

diff --git a/src/libraries/icubmod/rawValuesPublisherServer/RawValuesPublisherServer_ParamsParser.h b/src/libraries/icubmod/rawValuesPublisherServer/RawValuesPublisherServer_ParamsParser.h
@@ -14,6 +14,7 @@
 #ifndef RAWVALUESPUBLISHERSERVER_PARAMSPARSER_H
 #define RAWVALUESPUBLISHERSERVER_PARAMSPARSER_H
 
+// NOTE: commented code is kept to let device running with yarp 3.9. They can be removed when 3.10 available
 #include <yarp/os/Searchable.h>
 //#include <yarp/dev/IDeviceDriverParams.h>
 #include <string>
Original file line number	Diff line number	Diff line change
Expand Up		@@ -42,4 +42,3 @@ if(ICUB_USE_IPOPT)
		else()
		message(STATUS "IPOPT not found/selected, skipping optimization")
		endif()