-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
embObjIMU: add sensorName param #853
Conversation
f892356
to
25cc99c
Compare
25cc99c
to
84c0744
Compare
Successfully tested on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me but it'd better that @marcoaccame reviews the PR as well.
For people reviewing the PR, I suggest to look at it with whitespace changes hidden (see https://github.com/robotology/icub-main/pull/853/files?diff=unified&w=1). |
Ok for me, I wonder if we need also to update the template config files: https://github.com/robotology/robots-configuration/tree/master/iCubTemplates/iCubTemplateV6_0 as they are the only place in which all this configuration are documented. |
I am looking at it. I have seen that the description of the xml file is not exhaustive enough, so I am preparing a new description which takes into account all the possibilities of the device. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Nicogene, the PR is fine by me.
I will address the improvement of the relevant files in the following PR: |
Hi @marcoaccame The PR has been already merged |
sensorName
is optional, if defined it is used as return ofget<type>SensorName
and for now alsoget<type>FrameName
, (we should in the future also addframeName
as done #822 ) otherwiseid
is used.It fixes #852
cc @traversaro @marcoaccame @pattacini