Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embObjIMU: add sensorName param #853

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

Nicogene
Copy link
Member

@Nicogene Nicogene commented Jan 27, 2023

sensorName is optional, if defined it is used as return of get<type>SensorName and for now also get<type>FrameName, (we should in the future also add frameName as done #822 ) otherwise id is used.

It fixes #852

cc @traversaro @marcoaccame @pattacini

@Nicogene Nicogene self-assigned this Jan 27, 2023
@pattacini pattacini linked an issue Jan 27, 2023 that may be closed by this pull request
@Nicogene Nicogene force-pushed the addSensorNameEmbIMU branch 2 times, most recently from f892356 to 25cc99c Compare January 30, 2023 09:10
Nicogene added a commit to Nicogene/robots-configuration that referenced this pull request Jan 30, 2023
@Nicogene Nicogene marked this pull request as ready for review January 31, 2023 10:55
@Nicogene
Copy link
Member Author

Successfully tested on iCubGenova11 ready for the review

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me but it'd better that @marcoaccame reviews the PR as well.

@traversaro
Copy link
Member

For people reviewing the PR, I suggest to look at it with whitespace changes hidden (see https://github.com/robotology/icub-main/pull/853/files?diff=unified&w=1).

@traversaro
Copy link
Member

Ok for me, I wonder if we need also to update the template config files: https://github.com/robotology/robots-configuration/tree/master/iCubTemplates/iCubTemplateV6_0 as they are the only place in which all this configuration are documented.

@marcoaccame
Copy link
Contributor

marcoaccame commented Jan 31, 2023

Ok for me, I wonder if we need also to update the template config files: https://github.com/robotology/robots-configuration/tree/master/iCubTemplates/iCubTemplateV6_0 as they are the only place in which all this configuration are documented.

I am looking at it.

I have seen that the description of the xml file is not exhaustive enough, so I am preparing a new description which takes into account all the possibilities of the device.

Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Nicogene, the PR is fine by me.

@marcoaccame
Copy link
Contributor

Ok for me, I wonder if we need also to update the template config files: https://github.com/robotology/robots-configuration/tree/master/iCubTemplates/iCubTemplateV6_0 as they are the only place in which all this configuration are documented.

I am looking at it.

I have seen that the description of the xml file is not exhaustive enough, so I am preparing a new description which takes into account all the possibilities of the device.

I will address the improvement of the relevant files in the following PR:

@pattacini
Copy link
Member

Hi @marcoaccame

The PR has been already merged

@pattacini pattacini merged commit 8d0e005 into robotology:devel Jan 31, 2023
@Nicogene Nicogene deleted the addSensorNameEmbIMU branch February 1, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose sensorName parameter for embObjIMU
4 participants