-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New position files for soles and upper arms #931
Conversation
added position files for soles -> extracted from URDF model and rotated to correspond to the real robot added position files for upper arms -> extracted from CAD model and rotated to correspond to the real robot
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rustlluk
the PR looks pretty good. It would be very nice to have a couple screenshots showing the robot with the applied taxels for visual reference. Can you provide this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR can be merged straight away.
It would be very nice to have a couple screenshots showing the robot with the applied taxels for visual reference. Can you provide this?
I concur with @simeonedussoni. It'd be nice to have them before merging.
Thanks heaps! Look nice! Merging in |
This PR adds position files for the skin on left/right soles and upper arms.
How the files were created
Tests
@matejhof @BoPot