Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skinDynLib: fix missing body part id for the lowerbody #936

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

Nicogene
Copy link
Member

@Nicogene Nicogene commented Jan 23, 2024

This PR add the missing enums to the map used for defining the bodyPart

It fixes #933

TO BE TESTED
cc @traversaro @pattacini @rustlluk

@Nicogene Nicogene self-assigned this Jan 23, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

13.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@Nicogene Nicogene marked this pull request as ready for review January 29, 2024 15:59
@Nicogene
Copy link
Member Author

@traversaro pointed out that probably this part has to be refactored since the bodypart does not apply to not-humanoid robots, but the purpose of this PR is to fix the problem of the missing bodyPart, then the refactoring will be addressed later on

TO BE TESTED

Unfortunately, at this moment we don't have a robot with the skin in the legs, then we should merge and @rustlluk if you use it and find isse please let us know.

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roger 👍🏻
Awaiting the CI before merging.

@pattacini pattacini merged commit 852ec9e into robotology:master Jan 29, 2024
4 of 9 checks passed
@Nicogene Nicogene deleted the fix/skinLowerBody branch January 30, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong bodyPartId is assigned to skin on legs in skinContactList on /skinManager/skin_events:o
2 participants