Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set verbose elective option in 2FOC group to zero by defualt #964

Merged
merged 2 commits into from
May 31, 2024
Merged

Set verbose elective option in 2FOC group to zero by defualt #964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e05b37c
Fix bug when removing ethResource from LUT in clear method"
MSECode May 30, 2024
d01b019
Disable verbose by default changing its default value from 1 to 0
MSECode May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/libraries/icubmod/embObjLib/ethBoards.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,10 +219,8 @@ bool eth::EthBoards::rem(eth::AbstractEthResource* res)
return false;
}

for (auto& l : LUT)
{
l.clear();
}
auto& l = LUT[index];
l.clear();

sizeofLUT--;

Expand Down
6 changes: 3 additions & 3 deletions src/libraries/icubmod/embObjMotionControl/eomcParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1467,9 +1467,9 @@ bool Parser::parseFocGroup(yarp::os::Searchable &config, eomc::focBasedSpecificI
if (!extractGroup(focGroup, xtmp, "Verbose", "Verbose 0/1 ", _njoints, false))
{
//return false;
yWarning() << "In " << _boardname << " there isn't " << groupName << ". Verbose filed. For default it is enabled" ;
yWarning() << "In " << _boardname << " there isn't " << groupName << ". Verbose failed. By default it is disabled" ;
for (i = 0; i < (unsigned)_njoints; i++)
foc_based_info[i].verbose = 1;
foc_based_info[i].verbose = 0;
}
else
{
Expand All @@ -1481,7 +1481,7 @@ bool Parser::parseFocGroup(yarp::os::Searchable &config, eomc::focBasedSpecificI
if (!extractGroup(focGroup, xtmp, "AutoCalibration", "AutoCalibration 0/1 ", _njoints, false))
{
//return false;
yWarning() << "In " << _boardname << " there isn't " << groupName << ". AutoCalibration filed. For default it is disabled" ;
yWarning() << "In " << _boardname << " there isn't " << groupName << ". AutoCalibration failed. By default it is disabled" ;
for (i = 0; i < (unsigned)_njoints; i++)
AutoCalibration[i] = 0;
}
Expand Down