Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update feet collision #85

Merged
merged 3 commits into from
Jan 9, 2018
Merged

Update feet collision #85

merged 3 commits into from
Jan 9, 2018

Conversation

fiorisi
Copy link
Member

@fiorisi fiorisi commented Jan 5, 2018

Added the parameters to use a box for the foot collision geometry.

@fiorisi fiorisi requested a review from nunoguedelha January 5, 2018 19:47
nunoguedelha
nunoguedelha approved these changes Jan 9, 2018
View reviewed changes
Copy link
Contributor

@nunoguedelha nunoguedelha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me.

As a side note, since we are using the condition ICUB_PLUS to set the proper box origin, couldn't we apply the box collision shape just to the Gazebo model?

@fiorisi
Copy link
Member Author

fiorisi commented Jan 9, 2018

Yes, you are correct. I will address this in the next commit. Thanks!

@fiorisi fiorisi merged commit bc1ed77 into master Jan 9, 2018
@fiorisi fiorisi deleted the updateFeetCollision branch January 9, 2018 12:34
@traversaro traversaro mentioned this pull request Nov 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunoguedelha nunoguedelha nunoguedelha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fiorisi @nunoguedelha