Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dh-based generator for old iCub models #161

Closed
traversaro opened this issue Nov 3, 2020 · 1 comment · Fixed by #162 or #206
Closed

Remove dh-based generator for old iCub models #161

traversaro opened this issue Nov 3, 2020 · 1 comment · Fixed by #162 or #206
Assignees

Comments

@traversaro
Copy link
Member

To get rid of the legacy code contained in https://github.com/robotology/icub-model-generator/tree/master/dh, a possibility is to generate all hte possible combination of the models that can be obtained via icub_urdf_sdf_from_dh_generator command (see https://github.com/robotology/icub-model-generator/blob/master/dh/generator/icub_urdf_sdf_from_dh_generator.cpp), in particular for the binary options:

  • headV1/headV2
  • armsV1/armsV2
  • legsV1/legsV2
  • feetV1/feetV2

So we should obtain 16 URDF models with this naming:

  • icub-legacy-urdf-headV1-armsV1-legsV1-feetV1.urdf
  • ...
  • ...

Once we have that, the CMake macro generate_icub_dh should simply copy the appropriate model and install it.

@traversaro
Copy link
Member Author

This will be solved by #171 and a following cleanup PR. See also the related issue #96 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant