Apply suggestions from code review

Co-authored-by: Silvio Traversaro <silvio@traversaro.it>
robotology · Feb 16, 2022 · 5cf0b9a · 5cf0b9a
1 parent 8d7efc7
commit 5cf0b9a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/bindings/CMakeLists.txt b/bindings/CMakeLists.txt
@@ -62,7 +62,7 @@ if(ICUB_MODELS_COMPILE_PYTHON_BINDINGS)
       endif()
       file(WRITE ${CMAKE_CURRENT_BINARY_DIR}/METADATA "")
       file(APPEND ${CMAKE_CURRENT_BINARY_DIR}/METADATA "Metadata-Version: 2.1${NEW_LINE}")
-      file(APPEND ${CMAKE_CURRENT_BINARY_DIR}/METADATA "Name: icub_models${NEW_LINE}")
+      file(APPEND ${CMAKE_CURRENT_BINARY_DIR}/METADATA "Name: icub-models${NEW_LINE}")
       file(APPEND ${CMAKE_CURRENT_BINARY_DIR}/METADATA "Version: ${PROJECT_VERSION}${NEW_LINE}")
       file(WRITE ${CMAKE_CURRENT_BINARY_DIR}/INSTALLER "${ICUB_MODELS_PYTHON_PIP_METADATA_INSTALLER}${NEW_LINE}")
       install(

diff --git a/cpp/src/iCubModels.cpp.in b/cpp/src/iCubModels.cpp.in
@@ -11,7 +11,8 @@ namespace iCubModels
 {
 std::string getModelsPath()
 {
-    return "@ICUB_MODELS_MODELS_PATH@";
+    std::string retstr = "@ICUB_MODELS_MODELS_PATH@";
+    return retstr;
 }
 
 std::unordered_set<std::string> getRobotNames()