Fix to make sure that ROS2 can find the iCub package #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The added test are working fine as they are failing on ROS2, highlighting #177 . |
Nicogene
approved these changes
Nov 10, 2022
mebbaid
pushed a commit
to mebbaid/icub-models
that referenced
this pull request
Dec 1, 2022
mebbaid
added a commit
to mebbaid/icub-models
that referenced
this pull request
Dec 2, 2022
parent 530d017 author mebbaid <mohd-b-mohd@hotmail.com> 1669978606 +0100 committer mebbaid <mohd-b-mohd@hotmail.com> 1669978616 +0100 fix rebase conflict restore current version added missing velocityControlImplementationType param in config variables delete un-used config files add arm_no_hand config files to conf_manual Fix Hands weird position hand location fix fix r_hand collision group fix r_wrist_axis, play with camera sensors correct file name in l_eye sensor fix flipped pose of rgb sensors fix l_eye and r_eye pan axis Fix to make sure that ROS2 can find the iCub package (robotology#178)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #177 .
Furthermore, add tests to avoid regressions.