icub-models python library: Raise a FileNotFoundError if the model path is not found

[xela-95]

Instead of returning a placeholder Path("...") from

icub-models/python/icub_models/icub_models.py

Lines 32 to 38 in 468b9f7

	def get_model_file(robot_name: str) -> pathlib.Path:
	model_file = get_models_path() / robot_name / "model.urdf"
	if model_file.is_file():
	return model_file
	else:
	return pathlib.Path("...")

when the model name is not found I think it is more predictable and safe to raise an exception here.

[xela-95]

CC @traversaro

[traversaro]

I agree! Let's check what @GiulioRomualdi thinks.

[xela-95]

I think we need also to update the action versions here, like the pypi action is failing with:

Error: This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v2`. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

[traversaro]

I think we need also to update the action versions here, like the pypi action is failing with:

Error: This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v2`. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

Feel free to update it in this PR, thanks!

[traversaro]

(I changed the PR title to be more descriptive as it is going to be included in automatically generated changelog)

[xela-95]

I have updated the workflow actions and started using conda and miniforge instead of mamba and mambaforge as suggested in robotology/robotology-superbuild#1653. Now also the CI is passing. Ready for review.

[traversaro]

Thanks!

[xela-95]

@traversaro can you also bump a new minor version after this PR, to have a new conda package ready? Thanks!

[traversaro]

Sure, I can do the bump directly in this PR. @GiulioRomualdi can you quickly check the change?