Bump version to 3.0.0 and follow up in removal iCub3 files #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
changed the title
|
By the way, I forgot that we probably may want to include the icub 2.* gz-sim support, but this can be easily added after merging this PR, just before the tag. |
The documentation has references to icub3 (that has to be fixed) but the ros2 XML should be usable by icub2 too (cc @martinaxgloria) |
traversaro
commented
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we removed iCub 3 I think it make sense to bump the major version.
I also did a bit of follow up on #243 . @Nicogene can you also check the
ros2directory? It seems that it contains iCub3-related stuff, I wonder if we can remove it. It seems it was added in #184 .