Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iCub Manual Models used from build #43

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Conversation

pattacini
Copy link
Member

@pattacini pattacini commented Jul 26, 2020

This PR aims to fix the use of build tree for the newly created manual models.

Further, I've also taken the chance to fix what I think is a bug as the SDF version wasn't correctly reported in the model.config files.

@traversaro @xEnVrE please have a look!

@pattacini pattacini requested review from traversaro and xEnVrE July 26, 2020 11:39
@pattacini pattacini self-assigned this Jul 26, 2020
@pattacini pattacini force-pushed the fix/icub-manual-build branch from f5c08cb to b76383e Compare July 26, 2020 14:42
@traversaro
Copy link
Member

Thanks @pattacini for handling this. Given your modifications, I guess we need to remove the line:

install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/iCub_manual/ DESTINATION share/iCub)

otherwise (for example) the non-processed iCubGazeboV2_5_visuomanip/model.config will be copied instead of the one processed that is present in the build directory, and would be already installed by the line:

install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/iCub DESTINATION share)

@pattacini
Copy link
Member Author

pattacini commented Jul 27, 2020

That's right, I'll be doing a couple of tests more on this for confirmation and let you know asap (this afternoon).

@pattacini pattacini force-pushed the fix/icub-manual-build branch from b76383e to 5bc520e Compare July 27, 2020 07:50
@pattacini
Copy link
Member Author

Test successful @traversaro ✔️

@traversaro traversaro merged commit 1508bf4 into master Jul 27, 2020
@traversaro traversaro deleted the fix/icub-manual-build branch July 27, 2020 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants