[GravComp] Porting GravityCompensationHelper class from codyco-modules #438
Conversation
…s to iDynTree/Estimation
|
cc @traversaro |
| return true; | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
Can you add a newline at the end of this file? Otherwise @francesco-romano will complain. :D
See https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline .
| @@ -0,0 +1,122 @@ | |||
| #ifndef GRAVITY_COMPENSATION_HELPERS_H | |||
There was a problem hiding this comment.
Can you copy the copyright headers from the other files?
| @@ -0,0 +1,186 @@ | |||
| #include "iDynTree/Estimation/GravityCompensationHelpers.h" | |||
There was a problem hiding this comment.
The copyright header is necessary.
There was a problem hiding this comment.
Addded copyright header and newline in this commit: fd9efa9
|
Ok, thanks. Waiting for the CI to finish before merging. |
|
Meanwhile should I update the release docs ? If yes, let me know, which. |
|
Yes, please add a line in https://github.com/robotology/idyntree/blob/devel/doc/releases/v0_10.md . Thanks a lot for remembering that. |
Moved from https://github.com/robotology/codyco-modules/blob/master/src/devices/wholeBodyDynamics .